Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-29 Thread Van Haaren, Harry
.@marvell.com; dev@dpdk.org; > david.march...@redhat.com; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf > field > > 28/10/2020 11:24, Van Haaren, Harry: > > From: Thomas Monjalon > > > > + IP4_LOOKUP_N

Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Thomas Monjalon
28/10/2020 11:24, Van Haaren, Harry: > From: Thomas Monjalon > > > + IP4_LOOKUP_NODE_PRIV1_OFF(node->ctx) = node_mbuf_priv1_dynfield_offset; > > > > That's interesting. > > You copy the offset in the node context for better performance. > > How much is it better than with global offset variable? >

Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Thomas Monjalon
28/10/2020 11:42, Nithin Dabilpuram: > On Wed, Oct 28, 2020 at 10:24:01AM +, Van Haaren, Harry wrote: > > From: Thomas Monjalon > > > 28/10/2020 10:30, Nithin Dabilpuram: > > > > From: Thomas Monjalon > > > > > > > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > > > >

Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Nithin Dabilpuram
; ; Ruifeng Wang ; Richardson, Bruce > > ; Ananyev, Konstantin > > ; kirankum...@marvell.com; dev@dpdk.org; > > david.march...@redhat.com; olivier.m...@6wind.com > > Subject: Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic > > mbuf > > field &

Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Nithin Dabilpuram
On Wed, Oct 28, 2020 at 11:08:47AM +0100, Thomas Monjalon wrote: > 28/10/2020 10:30, Nithin Dabilpuram: > > From: Thomas Monjalon > > > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > > It is moved to a dynamic field in order to allow removal of udata64. > > > > Signed-o

Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Van Haaren, Harry
@dpdk.org; > david.march...@redhat.com; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf > field > > 28/10/2020 10:30, Nithin Dabilpuram: > > From: Thomas Monjalon > > > > The node_mbuf_priv1 was stored in the de

Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Thomas Monjalon
28/10/2020 10:30, Nithin Dabilpuram: > From: Thomas Monjalon > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > It is moved to a dynamic field in order to allow removal of udata64. > > Signed-off-by: Thomas Monjalon > Signed-off-by: Nithin Dabilpuram [...] > + IP4_L

[dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Nithin Dabilpuram
From: Thomas Monjalon The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. It is moved to a dynamic field in order to allow removal of udata64. Signed-off-by: Thomas Monjalon Signed-off-by: Nithin Dabilpuram --- lib/librte_node/ip4_lookup.c | 40 --