Re: [dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields

2021-10-12 Thread Gregory Etelson
Hello, ..snip.. > It was announced (commit f7383e7c7ec1). But > that's a good point: > - the removal of the deprecation is missing in the > patch I removed deprecation in v5 > - the message notice also talks about union for > fragment_offset A union for IPv4 fragmentation fields cannot be impl

Re: [dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields

2021-10-04 Thread Olivier Matz
On Mon, Oct 04, 2021 at 08:59:34AM -0700, Stephen Hemminger wrote: > On Mon, 4 Oct 2021 15:13:22 +0300 > Gregory Etelson wrote: > > > diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c > > index 951606f248..4f64be5357 100644 > > --- a/app/test/test_flow_classify.c > > +++

[dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields

2021-10-04 Thread Gregory Etelson
RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplified code to match on the IHL value in a flow rul

Re: [dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields

2021-10-04 Thread Stephen Hemminger
On Mon, 4 Oct 2021 15:13:22 +0300 Gregory Etelson wrote: > diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c > index 951606f248..4f64be5357 100644 > --- a/app/test/test_flow_classify.c > +++ b/app/test/test_flow_classify.c > @@ -95,7 +95,7 @@ static struct rte_acl_field_d