Re: [dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only

2018-05-23 Thread Varghese, Vipin
Hi Ferruh, I have checked the patch done. I am ok with the same. Thanks Vipin Varghese > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, May 23, 2018 1:41 PM > To: Wiles, Keith ; Varghese, Vipin > > Cc: DPDK ; ophi...@mellanox.com; tho...@monjalon.net; > ol...@mellanox.com >

Re: [dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only

2018-05-23 Thread Ferruh Yigit
On 5/23/2018 5:48 AM, Wiles, Keith wrote: > > >> On May 22, 2018, at 11:44 PM, Varghese, Vipin >> wrote: >> >> The TX function is shared between TAP and TUN PMD. Checking TUN-TAP >> type field will ensure the TAP PMD will always have protocol field >> as 0. >> >> Signed-off-by: Vipin Varghese

Re: [dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only

2018-05-22 Thread Wiles, Keith
> On May 22, 2018, at 11:44 PM, Varghese, Vipin > wrote: > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > type field will ensure the TAP PMD will always have protocol field > as 0. > > Signed-off-by: Vipin Varghese > Suggested-by: Ferruh Yigit > --- > Changes in V4:

[dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only

2018-05-22 Thread Vipin Varghese
The TX function is shared between TAP and TUN PMD. Checking TUN-TAP type field will ensure the TAP PMD will always have protocol field as 0. Signed-off-by: Vipin Varghese Suggested-by: Ferruh Yigit --- Changes in V4: - convert comparision with MACRO - Keith Wiles - add LOG err for tun using set

Re: [dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 11:04 PM, Ferruh Yigit wrote: > From: Vipin Varghese > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > type field will ensure the TAP PMD will always have protocol field > as 0. > > Signed-off-by: Vipin Varghese > Signed-off-by: Ferruh Yigit > --- > Cc: Oph

[dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only

2018-05-22 Thread Ferruh Yigit
From: Vipin Varghese The TX function is shared between TAP and TUN PMD. Checking TUN-TAP type field will ensure the TAP PMD will always have protocol field as 0. Signed-off-by: Vipin Varghese Signed-off-by: Ferruh Yigit --- Cc: Ophir Munk --- drivers/net/tap/rte_eth_tap.c | 66 ++