Re: [dpdk-dev] [PATCH v4] net/tap: fix device removal when no queues exist

2018-05-22 Thread Varghese, Vipin
r ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/tap: fix device removal when no queues > exist > > > > > On May 22, 2018, at 11:50 PM, Varghese, Vipin > wrote: > > > > Hi Ophir, > > > > One suggestion shared inline to email > >

Re: [dpdk-dev] [PATCH v4] net/tap: fix device removal when no queues exist

2018-05-22 Thread Wiles, Keith
> On May 22, 2018, at 11:50 PM, Varghese, Vipin > wrote: > > Hi Ophir, > > One suggestion shared inline to email > > > >> >> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c >> index >> c006d07..52ef799 100644 >> --- a/drivers/net/tap/rte_eth_tap.c >> +++ b/driv

Re: [dpdk-dev] [PATCH v4] net/tap: fix device removal when no queues exist

2018-05-22 Thread Varghese, Vipin
Hi Ophir, One suggestion shared inline to email > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index > c006d07..52ef799 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -929,6 +929,15 @@ tap_dev_close(struct rte_eth_dev

Re: [dpdk-dev] [PATCH v4] net/tap: fix device removal when no queues exist

2018-05-21 Thread Wiles, Keith
> On May 21, 2018, at 2:54 AM, Ophir Munk wrote: > > TAP device is created following its first queue creation. Multiple > queues can be added or removed over time. In Linux terminology those > are file descriptors which are opened or closed over time. As long as > the number of opened file desc

[dpdk-dev] [PATCH v4] net/tap: fix device removal when no queues exist

2018-05-21 Thread Ophir Munk
TAP device is created following its first queue creation. Multiple queues can be added or removed over time. In Linux terminology those are file descriptors which are opened or closed over time. As long as the number of opened file descriptors is positive - TAP device will appear as a Linux device.