Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix macsec setting

2019-10-29 Thread Ye Xiaolong
Hi, Guinan [snip] On 10/30, Sun GuinanX wrote: >+ >+void >+ixgbe_dev_macsec_register_set(struct rte_eth_dev *dev, I'd prefer to keep ixgbe_dev_macsec_register_enable since when it comes to HW register, `enable` is more accurate then `set` for this routine. And same for the below function, pre

[dpdk-dev] [PATCH v4] net/ixgbe: fix macsec setting

2019-10-29 Thread Sun GuinanX
macsec setting is not valid when port is stopped. In order to make it valid, the patch changes the setting to where port is started. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Sun GuinanX --- v4: * Deleted extra comments * Modified func