Re: [dpdk-dev] [PATCH v4] net/bonding: fix slave add for mode 4

2018-06-02 Thread Chas Williams
This certainly seems more correct to me. I can't think of a reason that you shouldn't be able to enslave whatever ports you like. Whether those ports can become active is a different question. I need to think about this a bit more before approval but I don't think it makes anything worse. The c

[dpdk-dev] [PATCH v4] net/bonding: fix slave add for mode 4

2018-06-01 Thread Radu Nicolau
Moved the link status validity check from the slave add to the slave activation step. Otherwise slave add will fail for mode 4 if the ports are all stopped but only one of them checked. Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions") Bugzilla ID: 52 Signed-off-by: Radu Ni