Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-11-05 Thread Shahaf Shuler
Tom, Monday, November 5, 2018 11:56 AM, Olivier Matz: > Subject: Re: [dpdk-dev] [PATCH v4] mlx5: Support for > rte_eth_rx_queue_count > > Hi Tom, > > On Mon, Nov 05, 2018 at 09:01:03AM +, Tom Barbette wrote: > > > > > It will tell you if in a given offset o

Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-11-05 Thread Olivier Matz
Hi Tom, On Mon, Nov 05, 2018 at 09:01:03AM +, Tom Barbette wrote: > > > It will tell you if in a given offset on the rxq you have a packet ready. I > > think it will fit your needs, see below. > So we just loose in precision here. We're looking at ML techniques that will > play better with

Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-11-05 Thread Tom Barbette
> It will tell you if in a given offset on the rxq you have a packet ready. I > think it will fit your needs, see below. So we just loose in precision here. We're looking at ML techniques that will play better with a numerical value and benefit from more entropy than arbitrarily poking of some

Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-11-01 Thread Shahaf Shuler
Wednesday, October 31, 2018 11:01 AM, Tom Barbette: > Subject: RE: [PATCH v4] mlx5: Support for rte_eth_rx_queue_count > > Hi Shahaf, > > I don't see how rte_eth_rx_descriptor_status can actually give me the > number of packets in the RX queue? It will tell me the status of a packet at a > given

Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-10-31 Thread Tom Barbette
Hi Shahaf, I don't see how rte_eth_rx_descriptor_status can actually give me the number of packets in the RX queue? It will tell me the status of a packet at a given offset, right? About the goal: we have a full view of a network (switches and servers), and we want to know where the queueing i

Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-10-28 Thread Shahaf Shuler
Hi Tom, Adding ethdev maintainers and Oliver as the author of the new API. Saturday, October 27, 2018 6:11 PM, Tom Barbette: > Subject: [PATCH v4] mlx5: Support for rte_eth_rx_queue_count > I have a more basic question. The rte_eth_rx_queue_count is a very old API, more or less from the begin

Re: [dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-10-28 Thread Tom Barbette
Thank you Yongseok for your comments ! Everything should be integrated in v4. However, it seems I was in vector mode... So now I cannot get my queue count. But the count seemed actually more or less correct. Are we speaking of a 4 packet error when in vector mode? Maybe we can actually accept t

[dpdk-dev] [PATCH v4] mlx5: Support for rte_eth_rx_queue_count

2018-10-27 Thread Tom Barbette
This patch adds support for the rx_queue_count API in mlx5 driver Changes in v2: * Fixed styling issues * Fix missing return Changes in v3: * Fix styling comments and checks as per Yongseok Koh comments. Thanks ! Changes in v4: * Fix compiling issue because of a line that disappeare