Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Akhil Goyal
Hi Anoob, One minor comment inline. Please correct it. Apart from that, Acked-by: Akhil Goyal Thanks. On 12/11/2017 9:05 PM, Anoob Joseph wrote: When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
Hi Akhil, Radu, I've updated the patch with the suggestions. But I think it will be better if we have two separate get_hop_for_offload_pkt() functions(for ipv4 & ipv6), since the return type etc is different. It might be cleaner that way. Thanks, Anoob On 12/11/2017 09:05 PM, Anoob Joseph

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending the packet on other ports could result in unencrypted packets being sent out. This would have performance improvements too, as the p