Re: [dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
07/10/2021 19:32, Ferruh Yigit: > Is 'ETH_RSS_L4_CHKSUM' left unchanged intentionally? > > #define ETH_RSS_L4_CHKSUM (1ULL << 35) No, I missed it when rebasing.

Re: [dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

2021-10-07 Thread Ferruh Yigit
On 10/7/2021 4:48 PM, Thomas Monjalon wrote: The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums f

[dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums for 64-bit variables. As they are enums, unsigne