Re: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-05-01 Thread Jerin Jacob
On Tue, Apr 26, 2022 at 5:38 PM Dumitrescu, Cristian wrote: > > Hi Jerin, Hi Cristian > > Thank you for implementing according to our agreement, I am happy to see that > we are converging. :-) > > Here are some comments below: > > > > > diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.

Re: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-05-01 Thread Jerin Jacob
On Tue, Apr 26, 2022 at 3:49 PM Ray Kinsella wrote: > > > jer...@marvell.com writes: > > > From: Jerin Jacob > > > > Currently, meter object supports only DSCP based on input color table, > > The patch enhance that to support VLAN based input color table, > > color table based on inner field for

RE: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-04-26 Thread Dumitrescu, Cristian
Hi Jerin, Thank you for implementing according to our agreement, I am happy to see that we are converging. Here are some comments below: > diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.h > index 40df0888c8..76ffbcf724 100644 > --- a/lib/ethdev/rte_mtr.h > +++ b/lib/ethdev/rte_mtr.h >

Re: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-04-26 Thread Ray Kinsella
jer...@marvell.com writes: > From: Jerin Jacob > > Currently, meter object supports only DSCP based on input color table, > The patch enhance that to support VLAN based input color table, > color table based on inner field for the tunnel use case, and > support for fallback color per meter if p

[dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-04-21 Thread jerinj
From: Jerin Jacob Currently, meter object supports only DSCP based on input color table, The patch enhance that to support VLAN based input color table, color table based on inner field for the tunnel use case, and support for fallback color per meter if packet based on a different field. All of