Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-31 Thread Andrew Rybchenko
On 10/30/19 6:49 PM, Olivier Matz wrote: Hi, On Wed, Oct 30, 2019 at 10:35:16AM +0300, Andrew Rybchenko wrote: @Olivier, please, take a look at the end of the mail. (...) On 10/29/19 8:19 PM, Slava Ovsiienko wrote: +}; + +/* Mbuf dynamic field offset for metadata. */ extern int +rte_flow_d

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-30 Thread Olivier Matz
Hi, On Wed, Oct 30, 2019 at 10:35:16AM +0300, Andrew Rybchenko wrote: > @Olivier, please, take a look at the end of the mail. > (...) > On 10/29/19 8:19 PM, Slava Ovsiienko wrote: > > > > +}; > > > > + > > > > +/* Mbuf dynamic field offset for metadata. */ extern int > > > > +rte_flow_dynf_meta

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-30 Thread Slava Ovsiienko
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, October 30, 2019 11:20 > To: Slava Ovsiienko ; Thomas Monjalon > ; olivier.m...@6wind.com > Cc: dev@dpdk.org; Matan Azrad ; Ori Kam > ; Yongseok Koh > Subject: Re: [dpdk-dev] [PATCH v4] ethdev: exte

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-30 Thread Slava Ovsiienko
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, October 30, 2019 11:00 > To: Andrew Rybchenko ; Thomas Monjalon > ; olivier.m...@6wind.com > Cc: dev@dpdk.org; Matan Azrad ; Ori Kam > ; Yongseok Koh > Subject: RE: [dpdk-dev] [PATCH v4] ethd

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-30 Thread Andrew Rybchenko
Monjalon ; Matan Azrad ; olivier.m...@6wind.com; Ori Kam ; Yongseok Koh Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata On 10/27/19 9:40 PM, Viacheslav Ovsiienko wrote: Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-30 Thread Slava Ovsiienko
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, October 30, 2019 9:35 > To: Slava Ovsiienko ; Thomas Monjalon > ; olivier.m...@6wind.com > Cc: dev@dpdk.org; Matan Azrad ; Ori Kam > ; Yongseok Koh > Subject: Re: [dpdk-dev] [PATCH v4] ethd

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-30 Thread Andrew Rybchenko
; olivier.m...@6wind.com; Ori Kam ; Yongseok Koh Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata On 10/27/19 9:40 PM, Viacheslav Ovsiienko wrote: Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Andrew Rybchenko
On 10/29/19 9:30 PM, Thomas Monjalon wrote: 29/10/2019 18:19, Slava Ovsiienko: From: Andrew Rybchenko --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst +* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed, static +metadata + mbuf field will be removed i

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 29, 2019 20:30 > To: Slava Ovsiienko > Cc: Andrew Rybchenko ; dev@dpdk.org; > Matan Azrad ; olivier.m...@6wind.com; Ori Kam > > Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metada

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Thomas Monjalon
29/10/2019 18:19, Slava Ovsiienko: > From: Andrew Rybchenko > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > +* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed, static > > > +metadata > > > + mbuf field will be removed in 20.02, metadat

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Slava Ovsiienko
> -Original Message- > From: Olivier Matz > Sent: Tuesday, October 29, 2019 18:34 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Thomas Monjalon ; Matan > Azrad ; Ori Kam ; Yongseok > Koh > Subject: Re: [PATCH v4] ethdev: extend flow metadata > > On Tue, Oct 29, 2019 at 05:25:22PM +0100, Oli

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Slava Ovsiienko
Hi, Olivier Thanks a lot for the review. > -Original Message- > From: Olivier Matz > Sent: Tuesday, October 29, 2019 18:25 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Thomas Monjalon ; Matan > Azrad ; Ori Kam ; Yongseok > Koh > Subject: Re: [PATCH v4] ethdev: extend flow metadata > > Hi

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Slava Ovsiienko
Hi, Andrew Thank you for the review. > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 29, 2019 18:22 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Thomas Monjalon ; Matan Azrad > ; olivier.m...@6wind.com; Ori Kam > ; Yongseok Koh > Subject:

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Olivier Matz
On Tue, Oct 29, 2019 at 05:25:22PM +0100, Olivier Matz wrote: > Hi Slava, > > Looks good to me overall. Few minor comments below. > > On Sun, Oct 27, 2019 at 06:40:36PM +, Viacheslav Ovsiienko wrote: > > Currently, metadata can be set on egress path via mbuf tx_metadata field > > with PKT_TX_

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Olivier Matz
Hi Slava, Looks good to me overall. Few minor comments below. On Sun, Oct 27, 2019 at 06:40:36PM +, Viacheslav Ovsiienko wrote: > Currently, metadata can be set on egress path via mbuf tx_metadata field > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. > > This patch

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-29 Thread Andrew Rybchenko
On 10/27/19 9:40 PM, Viacheslav Ovsiienko wrote: Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-27 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Subject: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata > > Currently, metadata can be set on egress path via mbuf tx_metadata field > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META

[dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-27 Thread Viacheslav Ovsiienko
Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a r