Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 9:34 PM fengchengwen wrote: > > @burce, jerin Some unmodified review comments are returned here: > > 1. > COMMENT: > +memset(dmadev_shared_data->data, 0, > > +sizeof(dmadev_shared_data->data)); > I believe all memzones are ze

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 06:10:48PM +0530, Jerin Jacob wrote: > On Fri, Jul 16, 2021 at 8:34 AM fengchengwen wrote: > > > > On 2021/7/16 0:33, Bruce Richardson wrote: > > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > > >> @burce, jerin Some unmodified review comments are return

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Jerin Jacob
On Fri, Jul 16, 2021 at 8:34 AM fengchengwen wrote: > > On 2021/7/16 0:33, Bruce Richardson wrote: > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > >> @burce, jerin Some unmodified review comments are returned here: > >> > > [snip] > > > > >> 2. COMMENT: > + * @see struct rte_

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Jerin Jacob
On Fri, Jul 16, 2021 at 3:20 PM Bruce Richardson wrote: > > On Fri, Jul 16, 2021 at 11:04:30AM +0800, fengchengwen wrote: > > On 2021/7/16 0:33, Bruce Richardson wrote: > > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > > >> @burce, jerin Some unmodified review comments are ret

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-16 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 11:04:30AM +0800, fengchengwen wrote: > On 2021/7/16 0:33, Bruce Richardson wrote: > > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > >> @burce, jerin Some unmodified review comments are returned here: > >> > > [snip] > > > > >> 2. COMMENT: > + * @see s

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
On 2021/7/16 0:33, Bruce Richardson wrote: > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: >> @burce, jerin Some unmodified review comments are returned here: >> [snip] > >> 2. COMMENT: > + * @see struct rte_dmadev_info::dev_capa >>> + */ >> Drop this flag as unnecessary. All d

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > @burce, jerin Some unmodified review comments are returned here: > > 1. > COMMENT: > + memset(dmadev_shared_data->data, 0, > > + sizeof(dmadev_shared_data->data)); > I believe all memzones ar

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
@burce, jerin Some unmodified review comments are returned here: 1. COMMENT: > +memset(dmadev_shared_data->data, 0, > +sizeof(dmadev_shared_data->data)); I believe all memzones are zero on allocation anyway, so this memset is unecessary and can be d

[dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v4: * replace xxx_complete_fails with xxx_completed_status. * add SILEN