Re: [dpdk-dev] [PATCH v4] app/testpmd: fix DCB set failure

2020-05-13 Thread Thomas Monjalon
13/05/2020 10:54, Iremonger, Bernard: > The fix is no longer in testpmd, so the commit line should be "ethdev: fix > DCB set failure". In general, the word "failure" (or error, etc) is not needed. Because it is a fix, we know there was a failure before :) And specifically here, you are not fixin

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix DCB set failure

2020-05-13 Thread Iremonger, Bernard
Hi Ting, > -Original Message- > From: dev On Behalf Of Ting Xu > Sent: Wednesday, May 13, 2020 11:08 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; > arybche...@solarflare.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v4] app/testpmd: fix DCB se

[dpdk-dev] [PATCH v4] app/testpmd: fix DCB set failure

2020-05-12 Thread Ting Xu
When set DCB in testpmd, there is a segmentation fault. It is because the local variable rss_conf in get_eth_dcb_conf() is not cleared, so that the pointer member variable rss_key has a random address, which leads to an error in the following processing. This patch initialized the local variable rs