Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Gaëtan Rivet
On Mon, Jan 08, 2018 at 02:00:54PM +, Matan Azrad wrote: > Hi Gaetan > > > > > Your environment does not include the function, but this is within > > > > fs_flow_destroy (please update to include the context by the way it > > > > helps a lot the review :). Afterward, line 162 ret is directl

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Monday, January 8, 2018 3:47 PM > On Mon, Jan 08, 2018 at 12:55:49PM +, Matan Azrad wrote: > > Hi Gaetan > > > > From: Gaëtan Rivet, Monday, January 8, 2018 12:58 PM > > > Hi Matan, > > > > > > Sorry for the delay on this. > > > > > > > It's OK in spite of I need

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Gaëtan Rivet
On Mon, Jan 08, 2018 at 12:55:49PM +, Matan Azrad wrote: > Hi Gaetan > > From: Gaëtan Rivet, Monday, January 8, 2018 12:58 PM > > Hi Matan, > > > > Sorry for the delay on this. > > > > It's OK in spite of I need to fetch it back :) > > > On Wed, Dec 20, 2017 at 10:58:29AM +, Matan Azra

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Monday, January 8, 2018 12:58 PM > Hi Matan, > > Sorry for the delay on this. > It's OK in spite of I need to fetch it back :) > On Wed, Dec 20, 2017 at 10:58:29AM +, Matan Azrad wrote: > > Hi Gaetan > > > > > -Original Message- > > > From: Gaëtan Rive

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2018-01-08 Thread Gaëtan Rivet
Hi Matan, Sorry for the delay on this. On Wed, Dec 20, 2017 at 10:58:29AM +, Matan Azrad wrote: > Hi Gaetan > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Wednesday, December 20, 2017 12:22 AM > > To: Matan Azrad > > Cc: Adrien Mazarguil ;

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2017-12-20 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, December 20, 2017 12:22 AM > To: Matan Azrad > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org > Subject: Re: [PATCH v3 6/6] net/failsafe: fix removed device handling > > Hi Mat

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2017-12-19 Thread Gaëtan Rivet
Hi Matan, On Tue, Dec 19, 2017 at 05:10:15PM +, Matan Azrad wrote: > There is time between the physical removal of the device until > sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and > applications still don't know about the removal and may call sub-device > control operation wh

[dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2017-12-19 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. In previous code this error is reported to the appl