Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 4:15 PM, Hunt, David wrote: What happens if someone sends a string with a "{" or "}" inside? If we get to the end of the buffer without a "}", it calls the library to convert, will fail, and move on.  No damage done (I hope). Also, a short un-terminated (by "}") string will also

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Hunt, David
On 25/9/2018 3:15 PM, Burakov, Anatoly wrote: On 25-Sep-18 3:00 PM, Hunt, David wrote: Now you're removing those newlines you added in previous commit :) Fixed in previous patch in the next version.   if (pol->pkt.core_type == CORE_TYPE_VIRTUAL) {   /*    * If the co

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 3:00 PM, Hunt, David wrote: Now you're removing those newlines you added in previous commit :) Fixed in previous patch in the next version.   if (pol->pkt.core_type == CORE_TYPE_VIRTUAL) {   /*    * If the cores in the policy are virtual, we need to map them

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Hunt, David
Hi Anatoly, On 25/9/2018 12:27 PM, Burakov, Anatoly wrote: On 14-Sep-18 2:54 PM, David Hunt wrote: Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentati

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Burakov, Anatoly
On 14-Sep-18 2:54 PM, David Hunt wrote: Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson

[dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-14 Thread David Hunt
Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson, a C library for encoding, decoding and m