Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-20 Thread Yuanhan Liu
On Fri, Mar 17, 2017 at 10:59:12AM +0100, Maxime Coquelin wrote: > > > On 03/17/2017 06:32 AM, Yuanhan Liu wrote: > >On Thu, Mar 16, 2017 at 12:37:23PM +0100, Maxime Coquelin wrote: > >> > >> > >>On 03/16/2017 09:00 AM, Yuanhan Liu wrote: > >>>On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coqu

Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-17 Thread Maxime Coquelin
On 03/17/2017 06:32 AM, Yuanhan Liu wrote: On Thu, Mar 16, 2017 at 12:37:23PM +0100, Maxime Coquelin wrote: On 03/16/2017 09:00 AM, Yuanhan Liu wrote: On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coquelin wrote: This patch implements the function for the application to get the MTU valu

Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-16 Thread Yuanhan Liu
On Thu, Mar 16, 2017 at 12:37:23PM +0100, Maxime Coquelin wrote: > > > On 03/16/2017 09:00 AM, Yuanhan Liu wrote: > >On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coquelin wrote: > >>This patch implements the function for the application to > >>get the MTU value. > > > >I'm thinking the other

Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-16 Thread Maxime Coquelin
On 03/16/2017 09:00 AM, Yuanhan Liu wrote: On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coquelin wrote: This patch implements the function for the application to get the MTU value. I'm thinking the other way. As we are making vhost being generic, it doesn't make too much sense now to sto

Re: [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-16 Thread Yuanhan Liu
On Sun, Mar 12, 2017 at 05:34:01PM +0100, Maxime Coquelin wrote: > This patch implements the function for the application to > get the MTU value. I'm thinking the other way. As we are making vhost being generic, it doesn't make too much sense now to store a net specific value at vhost layer. I'm t

[dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value

2017-03-12 Thread Maxime Coquelin
This patch implements the function for the application to get the MTU value. rte_vhost_get_mtu() fills the mtu parameter with the MTU value set in QEMU if VIRTIO_NET_F_MTU has been negotiated and returns 0, -ENOTSUP otherwise. The function returns -EAGAIN if Virtio feature negotiation didn't happ