Re: [dpdk-dev] [PATCH v3 3/7] eal: add sleep API

2021-02-23 Thread Nick Connolly
Hi Dmitry, +void +rte_thread_sleep(unsigned int sec) +{ + return Sleep(MS_PER_S * sec); +} There's probably no benefit in returning the 'void' value - I'd suggest just call Sleep(). Regards, Nick

[dpdk-dev] [PATCH v3 3/7] eal: add sleep API

2021-02-21 Thread Dmitry Kozlyuk
POSIX sleep(3) is missing from Windows. Add generic rte_thread_sleep() to suspend current OS thread. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_timer.c | 5 +++-- lib/librte_eal/include/rte_thread.h | 11 +++ lib/librte_eal/rte_eal_exports.def | 2 ++