Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-16 Thread Ananyev, Konstantin
> On 16 Sep 07:53, Ananyev, Konstantin wrote: > > Yes. we only has two gear. min or max. However, user still can customize > their system max with power mgmt python script on Intel platform. Ok, thanks for explanation. > > So rte_power_init(lcore) always raises lcore frequency to > > max possibl

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-16 Thread Liang, Ma
On 16 Sep 07:53, Ananyev, Konstantin wrote: Yes. we only has two gear. min or max. However, user still can customize their system max with power mgmt python script on Intel platform. > So rte_power_init(lcore) always raises lcore frequency to > max possible value? > > > > > > > > +rte_eth_remove

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-16 Thread Ananyev, Konstantin
> > > > > + > > > +switch (dev->cb_mode) { > > > +case RTE_ETH_DEV_POWER_MGMT_CB_WAIT: > > > +case RTE_ETH_DEV_POWER_MGMT_CB_PAUSE: > > > +rte_eth_remove_rx_callback(port_id, 0, > > > + dev->cur_pwr_cb); > > > +break; > > > +case RTE_ETH_DEV_POWER_MGMT_CB_SCALE: > > > +rte_power_freq_max(lcore

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-14 Thread Liang, Ma
On 04 Sep 11:33, Ananyev, Konstantin wrote: > > +struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > > + > > +if (unlikely(nb_rx == 0)) { > > +dev->empty_poll_stats[qidx].num++; > Hi Konstantin, Agree, v4 will relocate the meta data to seperate structure. and without touch the rte_ethde

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-14 Thread Liang, Ma
Hi Stephen, v4 will support 1 port with multiple core(still 1 queue per core)support this part description will be updated according to the design change. Regards Liang > The common way to express is this is: > > This API is not thread-safe and not preempt-safe. > There is also no mechan

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-04 Thread Ananyev, Konstantin
> > Add a simple on/off switch that will enable saving power when no > packets are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering an > architecture-defined optimized power state that will either wait > until a TSC timestamp

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:57 +0100 Liang Ma wrote: > Add a simple on/off switch that will enable saving power when no > packets are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering an > architecture-defined optimized power st

[dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-04 Thread Liang Ma
Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or w