Re: [dpdk-dev] [PATCH v3 3/5] test/ring: move common function to header file

2020-10-23 Thread Honnappa Nagarahalli
> > static inline void* > > test_ring_inc_ptr(void *obj, int esize, unsigned int n) { > > int sz; > > > > sz = esize; > > /* Legacy queue APIs? */ > > if ((esize) == -1) > > Extra (paren) doesn't help readability either +1

Re: [dpdk-dev] [PATCH v3 3/5] test/ring: move common function to header file

2020-10-23 Thread Stephen Hemminger
On Fri, 23 Oct 2020 23:54:22 + Honnappa Nagarahalli wrote: > > > > > > > Move test_ring_inc_ptr to header file so that it can be used by > > > functions in other files. > > > > > > Signed-off-by: Honnappa Nagarahalli > > > Reviewed-by: Dharmik Thakkar > > > --- > > > app/test/test_rin

Re: [dpdk-dev] [PATCH v3 3/5] test/ring: move common function to header file

2020-10-23 Thread Honnappa Nagarahalli
> > > Move test_ring_inc_ptr to header file so that it can be used by > > functions in other files. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Dharmik Thakkar > > --- > > app/test/test_ring.c | 11 --- app/test/test_ring.h | 11 > > +++ > > 2 files changed, 1

Re: [dpdk-dev] [PATCH v3 3/5] test/ring: move common function to header file

2020-10-23 Thread Ananyev, Konstantin
> Move test_ring_inc_ptr to header file so that it can be used by > functions in other files. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > --- > app/test/test_ring.c | 11 --- > app/test/test_ring.h | 11 +++ > 2 files changed, 11 insertions(+), 11 de

[dpdk-dev] [PATCH v3 3/5] test/ring: move common function to header file

2020-10-22 Thread Honnappa Nagarahalli
Move test_ring_inc_ptr to header file so that it can be used by functions in other files. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_ring.c | 11 --- app/test/test_ring.h | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff -