Re: [dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 9:48 AM, Yang, Qiming wrote: > Yes, etrack_id is an unique value. But not all NICs have this value. > I didn't find any value about fw version in fm10k. Yes, you are right, following is from i40e datasheet: " The EEPROM Manager tool writes a unique 32-bit eTrack_ID number in two sequ

Re: [dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get

2017-01-04 Thread Yang, Qiming
Yes, etrack_id is an unique value. But not all NICs have this value. I didn't find any value about fw version in fm10k. I40e is 8 bit too. firmware-version: 5.04 0x800024ca -Original Message- From: Yigit, Ferruh Sent: Wednesday, January 4, 2017 5:06 PM To: Yang, Qiming ; dev@dpdk.org; t

Re: [dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get

2017-01-04 Thread Ferruh Yigit
On 1/4/2017 2:44 AM, Yang, Qiming wrote: > You can see the kernel version ethtool, use command 'ethtool -i name>' > driver: ixgbe > version: 4.2.1-k > firmware-version: 0x61bf0001 > > Ixgbe's FW version do not have the major and minor number, and the original > purpose of this function is get F

Re: [dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get

2017-01-03 Thread Yang, Qiming
You can see the kernel version ethtool, use command 'ethtool -i ' driver: ixgbe version: 4.2.1-k firmware-version: 0x61bf0001 Ixgbe's FW version do not have the major and minor number, and the original purpose of this function is get FW version, so I think it's enough. -Original Message---

Re: [dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get

2017-01-03 Thread Ferruh Yigit
On 12/27/2016 12:30 PM, Qiming Yang wrote: > This patch add a new function ixgbe_fw_version_get. > > Signed-off-by: Qiming Yang <...> > > static void > +ixgbe_fw_version_get(struct rte_eth_dev *dev, __rte_unused u32 *fw_major, > + __rte_unused u32 *fw_minor, __rte_unused u32 *fw_patch, u

[dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get

2016-12-27 Thread Qiming Yang
This patch add a new function ixgbe_fw_version_get. Signed-off-by: Qiming Yang --- v3 changes: * use ixgbe_fw_version_get(struct rte_eth_dev *dev, __rte_unused u32 *fw_major, __rte_unused u32 *fw_minor, __rte_unused u32 *fw_patch, u32 *etrack_id) instead of ixgbe_fw_version_get(struct