Re: [dpdk-dev] [PATCH v3 3/3] ring: move the atomic load of head above the loop

2018-09-29 Thread Jerin Jacob
-Original Message- > Date: Mon, 17 Sep 2018 16:17:24 +0800 > From: Gavin Hu > To: dev@dpdk.org > CC: gavin...@arm.com, honnappa.nagaraha...@arm.com, steve.cap...@arm.com, > ola.liljed...@arm.com, jerin.ja...@caviumnetworks.com, n...@arm.com, > sta...@dpdk.org > Subject: [PATCH v3 3/3] ri

Re: [dpdk-dev] [PATCH v3 3/3] ring: move the atomic load of head above the loop

2018-09-29 Thread Stephen Hemminger
On Wed, 26 Sep 2018 10:06:36 + Justin He wrote: > Reviewed-by: Jia He > > Cheers, > Justin (Jia He) > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediate

Re: [dpdk-dev] [PATCH v3 3/3] ring: move the atomic load of head above the loop

2018-09-27 Thread Justin He
> -Original Message- > From: Gavin Hu (Arm Technology China) > Sent: 2018年9月26日 17:30 > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: Honnappa Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org; Justin > He > Subject: RE: [PA

Re: [dpdk-dev] [PATCH v3 3/3] ring: move the atomic load of head above the loop

2018-09-26 Thread Gavin Hu (Arm Technology China)
+Justin He for review > -Original Message- > From: Gavin Hu > Sent: Monday, September 17, 2018 4:17 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org > Subject: [PA

[dpdk-dev] [PATCH v3 3/3] ring: move the atomic load of head above the loop

2018-09-17 Thread Gavin Hu
In __rte_ring_move_prod_head, move the __atomic_load_n up and out of the do {} while loop as upon failure the old_head will be updated, another load is costly and not necessary. This helps a little on the latency,about 1~5%. Test result with the patch(two cores): SP/SC bulk enq/dequeue (size: 8