Re: [dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-18 Thread Stephen Hemminger
On Wed, 18 Apr 2018 14:19:52 +0100 Ferruh Yigit wrote: > > +/* enables testpmd to collect per queue stats. */ > > +static int > > +hn_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *eth_dev, > > + __rte_unused uint16_t queue_id, > > + __r

Re: [dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-18 Thread Stephen Hemminger
> > +/* XXX Why is this not generic in RTE? */ > > +static int > > +hn_dev_atomic_write_link_status(struct rte_eth_dev *dev, > > + struct rte_eth_link *link) > > +{ > > It is indeed generic now thanks to you :) > Can you switch to your generic functions? Will change in v4. This driv

Re: [dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > The driver supports Hyper-V networking directly like > virtio for KVM or vmxnet3 for VMware. > > This code is based off of the FreeBSD driver. The file and variable > names are kept the same to help with understanding

[dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-17 Thread Stephen Hemminger
From: Stephen Hemminger The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). Signed-off-by: St