Re: [dpdk-dev] [PATCH v3 2/2] net/ice: add safe mode support devarg

2019-07-10 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, July 10, 2019 3:29 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 2/2] net/ice: add safe mode support devarg > > > > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, July 10,

Re: [dpdk-dev] [PATCH v3 2/2] net/ice: add safe mode support devarg

2019-07-10 Thread Ray Kinsella
Acked-by: Ray Kinsella On 10/07/2019 05:16, Qi Zhang wrote: > Safe mode support is not necessary by default. > Driver be initialized without OS package silently may confuse users > since most advanced feature are disabled. > Add devarg for safe mode enabling only for when user intend to do this.

Re: [dpdk-dev] [PATCH v3 2/2] net/ice: add safe mode support devarg

2019-07-10 Thread Yang, Qiming
-Original Message- From: Zhang, Qi Z Sent: Wednesday, July 10, 2019 12:17 PM To: Yang, Qiming ; Lu, Wenzhuo Cc: dev@dpdk.org; Zhang, Qi Z Subject: [PATCH v3 2/2] net/ice: add safe mode support devarg Safe mode support is not necessary by default. Driver be initialized without OS pack

[dpdk-dev] [PATCH v3 2/2] net/ice: add safe mode support devarg

2019-07-09 Thread Qi Zhang
Safe mode support is not necessary by default. Driver be initialized without OS package silently may confuse users since most advanced feature are disabled. Add devarg for safe mode enabling only for when user intend to do this. Signed-off-by: Qi Zhang --- -v3: fix wrong logic in parse_bool. -