Re: [dpdk-dev] [PATCH v3 2/2] ethdev: complete closing of port

2018-10-16 Thread Thomas Monjalon
16/10/2018 13:24, Andrew Rybchenko: > On 10/15/18 2:20 AM, Thomas Monjalon wrote: > > After closing a port, it cannot be restarted. > > So there is no reason to not free all associated resources. > > > > The last step was done with rte_eth_dev_detach() which is deprecated. > > Instead of blindly re

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: complete closing of port

2018-10-16 Thread Andrew Rybchenko
On 10/15/18 2:20 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should che

[dpdk-dev] [PATCH v3 2/2] ethdev: complete closing of port

2018-10-14 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is