Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-04-10 Thread Jerin Jacob
-Original Message- > Date: Fri, 7 Apr 2017 17:47:40 + > From: "Dumitrescu, Cristian" > To: Jerin Jacob > CC: "dev@dpdk.org" , "thomas.monja...@6wind.com" > , "balasubramanian.manoha...@cavium.com" > , "hemant.agra...@nxp.com" > , "shreyansh.j...@nxp.com" > > Subject: RE: [PATCH v

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-04-07 Thread Dumitrescu, Cristian
Hi Jerin, Thanks for your review! > > Thanks Cristian for v3. > > From Cavium HW perceptive, v3 is in relatively good shape to consume it, > Except the below mentioned two pointers. > > 1) We strongly believes, application explicitly need to give level id, while > creating topology(i.e rte_tm_

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-04-07 Thread Dumitrescu, Cristian
Hi Hemant, Thanks for your input! ... > > +/** > > + * Traffic manager dynamic updates > > + */ > > +enum rte_tm_dynamic_update_type { > > + /**< Dynamic parent node update. The new parent node is located > on same > > +* hierarchy level as the former parent node. Consequently, the > node

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-04-07 Thread Jerin Jacob
-Original Message- > Date: Sat, 4 Mar 2017 01:10:20 + > From: Cristian Dumitrescu > To: dev@dpdk.org > CC: thomas.monja...@6wind.com, jerin.ja...@caviumnetworks.com, > balasubramanian.manoha...@cavium.com, hemant.agra...@nxp.com, > shreyansh.j...@nxp.com > Subject: [PATCH v3 2/2] eth

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-30 Thread Hemant Agrawal
Hi Cristian, On 3/4/2017 6:40 AM, Cristian Dumitrescu wrote: This patch introduces the generic ethdev API for the traffic manager capability, which includes: hierarchical scheduling, traffic shaping, congestion management, packet marking. Main features: - Exposed as ethdev plugin capabi

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-24 Thread Dumitrescu, Cristian
> > No there is no such policy on a next- tree. > > It is free to the maintainer of the tree I guess. > > Thanks, Thomas. Can you please create a next-tree for QoS Traffic > Management with the following details: > Maintainer: Cristian > Committers: Hemant, Jerin, Cristian Hi Thomas,

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Thursday, March 16, 2017 6:11 PM > To: Dumitrescu, Cristian ; Ananyev, > Konstantin > Cc: O'Driscoll, Tim ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hema

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Thomas Monjalon
2017-03-16 17:40, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-03-16 16:23, Dumitrescu, Cristian: > > > ... > > > > > > > > Thomas, given Tim's confirmation of Intel's plans to implement this > > > > > API > > for > > > > the ixgbe and i40e drivers in

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Thursday, March 16, 2017 5:30 PM > To: Dumitrescu, Cristian > Cc: O'Driscoll, Tim ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > sh

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Thomas Monjalon
2017-03-04 01:10, Cristian Dumitrescu: > This patch introduces the generic ethdev API for the traffic manager > capability, which includes: hierarchical scheduling, traffic shaping, > congestion management, packet marking. > > Main features: > - Exposed as ethdev plugin capability (similar to rte_

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Thomas Monjalon
2017-03-16 16:23, Dumitrescu, Cristian: > ... > > > > Thomas, given Tim's confirmation of Intel's plans to implement this API > > > for > > the ixgbe and i40e drivers in DPDK release 17.8, are you in favour of > > including > > this API in 17.5 with experimental tag (subject to full API agreeme

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-16 Thread Dumitrescu, Cristian
... > > Thomas, given Tim's confirmation of Intel's plans to implement this API for > the ixgbe and i40e drivers in DPDK release 17.8, are you in favour of > including > this API in 17.5 with experimental tag (subject to full API agreement being > reached)? > > I think starting a branch in a de

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-15 Thread Thomas Monjalon
2017-03-10 18:37, Dumitrescu, Cristian: > From: O'Driscoll, Tim > > > > OK I better understand now. > > > > You should add this level of explanation in your patch. > > > > > > > > However I am reluctant to add an API if there is no user. > > > > I think we should wait to have at least one existing

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-10 Thread Dumitrescu, Cristian
> -Original Message- > From: O'Driscoll, Tim > Sent: Wednesday, March 8, 2017 9:52 AM > To: Dumitrescu, Cristian ; Thomas Monjalon > > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com; Wiles, Keith

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-08 Thread O'Driscoll, Tim
> From: Dumitrescu, Cristian > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > Sent: Monday, March 6, 2017 8:07 PM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > > balasubramanian.manoha...@cavium.com; hemant.ag

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 6, 2017 8:07 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com; W

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Thomas Monjalon
2017-03-06 16:59, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-03-04 01:10, Cristian Dumitrescu: > > > This patch introduces the generic ethdev API for the traffic manager > > > capability, which includes: hierarchical scheduling, traffic shaping, > > >

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Dumitrescu, Cristian
vium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com > Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler > API > > On Sat, 4 Mar 2017 01:10:20 + > Cristian Dumitrescu wrote: > > > +/* Get generic traffic manager operations struct

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 6, 2017 10:39 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com >

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Stephen Hemminger
On Sat, 4 Mar 2017 01:10:20 + Cristian Dumitrescu wrote: > +/* Get generic traffic manager operations structure from a port. */ > +const struct rte_tm_ops * > +rte_tm_ops_get(uint8_t port_id, struct rte_tm_error *error) > +{ > + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > +

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-06 Thread Thomas Monjalon
2017-03-04 01:10, Cristian Dumitrescu: > This patch introduces the generic ethdev API for the traffic manager > capability, which includes: hierarchical scheduling, traffic shaping, > congestion management, packet marking. We already have some API for QoS. Why integrating them in ethdev? ethdev is

[dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-03 Thread Cristian Dumitrescu
This patch introduces the generic ethdev API for the traffic manager capability, which includes: hierarchical scheduling, traffic shaping, congestion management, packet marking. Main features: - Exposed as ethdev plugin capability (similar to rte_flow approach) - Capability query API per port, per