Re: [dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support

2018-07-12 Thread Shreyansh Jain
On Thursday 12 July 2018 05:53 PM, Thomas Monjalon wrote: Title can be "net/dpaa: support scatter offload" 06/07/2018 10:10, Hemant Agrawal: + /* Max packet can fit in single buffer */ + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) { + ; Why an empty stat

Re: [dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support

2018-07-12 Thread Thomas Monjalon
Title can be "net/dpaa: support scatter offload" 06/07/2018 10:10, Hemant Agrawal: > + /* Max packet can fit in single buffer */ > + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) { > + ; Why an empty statement? > + } else if (dev->data->dev_conf.rxmode.enable_s

[dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support

2018-07-06 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 75 +- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa/dpaa_rxtx.c | 4 +-- drivers/net/dpaa/dpaa_rxtx.h | 2 -- 4 files changed, 70 insertions(+), 1