Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-04-01 Thread Eads, Gage
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Monday, April 1, 2019 12:41 PM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Gavin Hu (Arm Technology Chin

Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-04-01 Thread Honnappa Nagarahalli
> > > > +static ssize_t > > > +rte_stack_get_memsize(unsigned int count) { > > > + ssize_t sz = sizeof(struct rte_stack); > > > + > > > + /* Add padding to avoid false sharing conflicts */ > > > + sz += RTE_CACHE_LINE_ROUNDUP(count * sizeof(void *)) + > > > + 2 * RTE_CACHE_LINE_SIZE; > > I

Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-03-29 Thread Thomas Monjalon
29/03/2019 20:23, Eads, Gage: > @Thomas: I expect I can address Honnappa's feedback within a day or two. > Since today is the 19.05 merge deadline, what do you think about these > options for merging? > 1. Merge V4 now and address these comments during RC1. > 2. Delay merge until RC2, with all co

Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-03-29 Thread Eads, Gage
@Thomas: I expect I can address Honnappa's feedback within a day or two. Since today is the 19.05 merge deadline, what do you think about these options for merging? 1. Merge V4 now and address these comments during RC1. 2. Delay merge until RC2, with all comments addressed. In terms of risk, Hon

Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-03-28 Thread Honnappa Nagarahalli
Hi Gage, Apologies for the late comments. > -Original Message- > From: Gage Eads > Sent: Wednesday, March 6, 2019 8:46 AM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; > bruce.richard...@intel.com; konstantin.anan...@intel.com; Gavin Hu (Arm > Technol

Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-03-14 Thread Olivier Matz
On Wed, Mar 06, 2019 at 08:45:52AM -0600, Gage Eads wrote: > The rte_stack library provides an API for configuration and use of a > bounded stack of pointers. Push and pop operations are MT-safe, allowing > concurrent access, and the interface supports pushing and popping multiple > pointers at a t

[dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-03-06 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st