Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-06 Thread Ori Kam
Hi > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, October 6, 2021 11:38 AM > data > > On 10/6/21 11:30 AM, Thomas Monjalon wrote: > > 05/10/2021 13:11, Andrew Rybchenko: > >> On 10/5/21 1:10 PM, Ori Kam wrote: > >>> From: Andrew Rybchenko > On 10/5/21 12:41 PM, Or

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-06 Thread Andrew Rybchenko
On 10/6/21 11:30 AM, Thomas Monjalon wrote: > 05/10/2021 13:11, Andrew Rybchenko: >> On 10/5/21 1:10 PM, Ori Kam wrote: >>> From: Andrew Rybchenko On 10/5/21 12:41 PM, Ori Kam wrote: > From: Andrew Rybchenko >> On 10/5/21 11:17 AM, Ori Kam wrote: >>> One more thing, I think this

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-06 Thread Thomas Monjalon
05/10/2021 13:11, Andrew Rybchenko: > On 10/5/21 1:10 PM, Ori Kam wrote: > > From: Andrew Rybchenko > >> On 10/5/21 12:41 PM, Ori Kam wrote: > >>> From: Andrew Rybchenko > On 10/5/21 11:17 AM, Ori Kam wrote: > > One more thing, I think this flag should be added now since you need > >

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 5, 2021 1:02 PM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > Hi Ori, > > On 10/5/21 12:41 PM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message-

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 5, 2021 11:39 AM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > Hi Ori, > > On 10/5/21 11:17 AM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message-

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 5, 2021 10:27 AM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > On 10/5/21 9:30 AM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: An

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
Hi Ori, On 10/5/21 1:10 PM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 5, 2021 1:02 PM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> Hi Ori, >> >> On 10/5/21 12:41 PM, Ori Kam wro

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 4, 2021 4:53 PM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > On 10/4/21 2:39 PM, Ivan Malov wrote: > > On 04/10/2021 09:56, Ori Kam wrote: > >>> On 04/10/2021 00:0

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
Hi Ori, On 10/5/21 12:41 PM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 5, 2021 11:39 AM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> Hi Ori, >> >> On 10/5/21 11:17 AM, Ori Kam w

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
Hi Ori, On 10/5/21 11:17 AM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 5, 2021 10:27 AM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> On 10/5/21 9:30 AM, Ori Kam wrote: >>> Hi An

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-05 Thread Andrew Rybchenko
On 10/5/21 9:30 AM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, October 4, 2021 4:53 PM >> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta >> data >> >> On 10/4/21 2:39 PM, Ivan Malov wrote: >>> On 04/10/2021 0

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-04 Thread Andrew Rybchenko
On 10/4/21 2:39 PM, Ivan Malov wrote: > On 04/10/2021 09:56, Ori Kam wrote: >>> On 04/10/2021 00:04, Ori Kam wrote: I understand that you are only talking about enabling the action, meaning to let the PMD know that at some point there will be a rule that will use the mark action for

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-04 Thread Ivan Malov
Hi Ori, On 04/10/2021 09:56, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Monday, October 4, 2021 2:50 AM Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data Hi Ori, On 04/10/2021 00:04, Ori Kam wrote: Hi Ivan, Sorry for the long

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-04 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Monday, October 4, 2021 2:50 AM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > Hi Ori, > > On 04/10/2021 00:04, Ori Kam wrote: > > Hi Ivan, > > > > Sorry for the long review. > > > >> ---

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-03 Thread Ori Kam
Hi Ivan, Sorry for the long review. > -Original Message- > From: Ivan Malov > Sent: Sunday, October 3, 2021 8:30 PM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > Hi Ori, > > On 03/10/2021 14:01, Ori Kam wrote: > > Hi Ivan, > > > >> -Origi

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-03 Thread Ivan Malov
Hi Ori, On 04/10/2021 00:04, Ori Kam wrote: Hi Ivan, Sorry for the long review. -Original Message- From: Ivan Malov Sent: Sunday, October 3, 2021 8:30 PM Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data Hi Ori, On 03/10/2021 14:01, Ori Kam wrote: H

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-03 Thread Ivan Malov
Hi Ori, On 03/10/2021 14:01, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Sunday, October 3, 2021 12:30 PM data Hi Ori, Thanks for reviewing this. No problem. On 03/10/2021 10:42, Ori Kam wrote: Hi Andrew and Ivan, -Original Message- From: Andre

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-03 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Sunday, October 3, 2021 12:30 PM > data > > Hi Ori, > > Thanks for reviewing this. > No problem. > On 03/10/2021 10:42, Ori Kam wrote: > > Hi Andrew and Ivan, > > > > > >> -Original Message- > >> From: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-03 Thread Ori Kam
Hi Andrew and Ivan, > -Original Message- > From: Andrew Rybchenko > Sent: Friday, October 1, 2021 9:50 AM > Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta > data > > On 9/30/21 10:07 PM, Ivan Malov wrote: > > Hi Ori, > > > > On 30/09/2021 17:59, Ori Kam wro

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-03 Thread Ori Kam
Hi > -Original Message- > From: Ivan Malov > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery > of Rx meta data > > > > On 01/10/2021 01:12, Ajit Khaparde wrote: > > On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov > wrote: >

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-10-03 Thread Ivan Malov
Hi Ori, Thanks for reviewing this. On 03/10/2021 10:42, Ori Kam wrote: Hi Andrew and Ivan, -Original Message- From: Andrew Rybchenko Sent: Friday, October 1, 2021 9:50 AM Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data On 9/30/21 10:07 PM, Ivan Mal

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Andrew Rybchenko
On 9/30/21 10:07 PM, Ivan Malov wrote: > Hi Ori, > > On 30/09/2021 17:59, Ori Kam wrote: >> Hi Ivan, >> Sorry for jumping in late. > > No worries. That's OK. > >> I have a concern that this patch breaks other PMDs. > > It does no such thing. > >>> From the rst file " One should negotiate flag

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ajit Khaparde
On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov wrote: > > Hi Ajit, > > On 01/10/2021 00:48, Ajit Khaparde wrote: > > > >> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > >> index 97ae52e17e..7a8da3d7ab 100644 > >> --- a/app/test-pmd/testpmd.c > >> +++ b/app/test-pmd/testpmd.c > >>

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ajit Khaparde
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 97ae52e17e..7a8da3d7ab 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1485,10 +1485,36 @@ static void > init_config_port_offloads(portid_t pid, uint32_t socket_id) > { > struct rte_port

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
On 01/10/2021 01:12, Ajit Khaparde wrote: On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov wrote: Hi Ajit, On 01/10/2021 00:48, Ajit Khaparde wrote: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17e..7a8da3d7ab 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Ajit, On 01/10/2021 00:48, Ajit Khaparde wrote: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17e..7a8da3d7ab 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1485,10 +1485,36 @@ static void init_config_port_offloads(portid_t pid, uint32

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Ori, On 30/09/2021 17:59, Ori Kam wrote: Hi Ivan, Sorry for jumping in late. No worries. That's OK. I have a concern that this patch breaks other PMDs. It does no such thing. From the rst file " One should negotiate flag delivery beforehand" since you only added this function for you

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ori Kam
Hi Ivan, Sorry for jumping in late. I have a concern that this patch breaks other PMDs. >From the rst file " One should negotiate flag delivery beforehand" since you only added this function for your PMD all other PMD will fail. I see that you added exception in the examples, but it doesn't make

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Andrew Rybchenko
Hi Ori, On 9/30/21 5:59 PM, Ori Kam wrote: > Hi Ivan, > Sorry for jumping in late. > > I have a concern that this patch breaks other PMDs. >>From the rst file " One should negotiate flag delivery beforehand" > since you only added this function for your PMD all other PMD will fail. > I see that y

[dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-23 Thread Ivan Malov
Delivery of mark, flag and the likes might affect small packet performance. If these features are disabled by default, enabling them in started state without causing traffic disruption may not always be possible. Let applications negotiate delivery of Rx meta data beforehand. Signed-off-by: Ivan