Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-04 Thread Wu, Jingjing
> > Different HW may have different version format, so it is better to use > > string. > > > > And I prefer the API definition in your v2 patch like > > > > rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int > > fw_length); > > The problem with this is the format and content of the stri

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-04 Thread Ferruh Yigit
lon >> >> Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get >> >> Yes, in my opinion it is. And I use this name already exist in the share >> code from >> ND team. >> >> -Original Message- >> From: Yigit, Ferruh >

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-03 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Qiming > Sent: Wednesday, January 4, 2017 11:33 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; Horton, Remy ; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add fir

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-03 Thread Yang, Qiming
Yes, in my opinion it is. And I use this name already exist in the share code from ND team. -Original Message- From: Yigit, Ferruh Sent: Tuesday, January 3, 2017 10:49 PM To: Yang, Qiming Cc: dev@dpdk.org; Horton, Remy ; Thomas Monjalon Subject: Re: [PATCH v3 1/4] ethdev: add firmware

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-03 Thread Ferruh Yigit
On 12/27/2016 12:30 PM, Qiming Yang wrote: > This patch adds a new API 'rte_eth_dev_fw_info_get' for fetching > firmware related information by a given device. > > Signed-off-by: Qiming Yang > Acked-by: Remy Horton > --- > v2 changes: > * modified some comment statements. > v3 changes: > * chang

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-03 Thread Ferruh Yigit
On 1/3/2017 9:05 AM, Yang, Qiming wrote: > Hi, Ferruh > Please see the question below. In my opinion, etrack_id is just a name used > to define the ID of one NIC. > In kernel version ethtool, it will print this ID in the line of firmware > verison. > I know what is etrack_id mean, but I really d

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-03 Thread Yang, Qiming
Hi, Ferruh Please see the question below. In my opinion, etrack_id is just a name used to define the ID of one NIC. In kernel version ethtool, it will print this ID in the line of firmware verison. I know what is etrack_id mean, but I really don't know why this named etrack_id. Can you explain t

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2017-01-02 Thread Thomas Monjalon
2016-12-27 20:30, Qiming Yang: > /** > + * Retrieve the firmware version of a device. > + * > + * @param port_id > + * The port identifier of the device. > + * @param fw_major > + * A array pointer to store the major firmware version of a device. > + * @param fw_minor > + * A array pointer t

[dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get

2016-12-27 Thread Qiming Yang
This patch adds a new API 'rte_eth_dev_fw_info_get' for fetching firmware related information by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- v2 changes: * modified some comment statements. v3 changes: * change API, use rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t