Hi Cristian,
New patch has been submitted. All comments are fixed except this one:
"Here is one bug for you, you need to make sure you add the following line
here:
param->parsed = 1;"
I think the new convention is to set this flag by the
macro PARSE_CHECK_DUPLICATE_SECTION.
BTW, although
Hi Ethan,
Thanks very much for sending the new version.
You are absolutely right about the param->parsed issue, sorry, my fault.
I think you need to use the --cover-letter flag for git format-patch command.
You can practice by sending the patch set to your email address first before
you send i
Hi Ethan,
Thank you, here are some comments inlined below.
Please reorganize this patch in a slightly different way to look similar to
other DPDK patch sets and also ease up the integration work for Thomas:
Patch 0: I suggest adding a cover letter;
Patch 1: all librte_port change
1. add KNI port type to the packet framework
2. add KNI support to the IP Pipeline sample Application
3. some bug fix
Signed-off-by: WeiJie Zhuang
---
v2:
* Fix check patch error.
v3:
* Fix code review comments.
---
doc/api/doxy-api-index.md | 1 +
examples/ip_pipeline
4 matches
Mail list logo
