Re: [dpdk-dev] [PATCH v3 1/3] ethdev: fix adding invalid MAC addr

2017-04-12 Thread Nélio Laranjeiro
Hi, note, please use the --thread option in addition of the in-reply-to to new series. Small comments inline, On Wed, Apr 12, 2017 at 05:02:24PM +0800, Wei Dai wrote: >[...] > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index ff903e6..91fc4c4 100644 > --- a/drivers/net/mlx4/

[dpdk-dev] [PATCH v3 1/3] ethdev: fix adding invalid MAC addr

2017-04-12 Thread Wei Dai
some customers find adding mac addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wei