Re: [dpdk-dev] [PATCH v3 1/2] net/tap: add eBPF instructions to TAP device

Hi Pascal, Please see inline > -Original Message- > From: Pascal Mazon [mailto:pascal.ma...@6wind.com] > Sent: Wednesday, January 10, 2018 11:35 AM > To: Ophir Munk ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > > Subject: Re: [PATCH v3 1/2] net/tap: add eBPF instructions to TAP devi

Re: [dpdk-dev] [PATCH v3 1/2] net/tap: add eBPF instructions to TAP device

Hi Ophir, I have a few remarks. - Why do you define ARRAY_SIZE in tap_flow.h while it's used only in tap_bpf_insns.c? - I really dislike having the BPF bytecode hardcoded in tap_bpf_insns.c.   You don't provide the commands used to generate that bytecode.   And you don't provide the way to trans

[dpdk-dev] [PATCH v3 1/2] net/tap: add eBPF instructions to TAP device

TAP PMD is required to support RSS queue mapping based on rte_flow API. An example usage for this requirement is failsafe transparent switching from a PCI device to TAP device while keep redirecting packets to the same RSS queues on both devices. TAP RSS implementation is based on eBPF programs se