Re: [dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks

2018-04-24 Thread Hemant Agrawal
HI Ferruh, > Hi Hemant, > > Overall this looks good to me, thanks. > > Only I would like to ask if you prefer to replace nodis and not_supported > checks. > > Because with current order, if an offlaod requested that both has not > supported > offload and not enable all nodis offloads, this w

Re: [dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks

2018-04-24 Thread Ferruh Yigit
On 4/24/2018 4:06 PM, Hemant Agrawal wrote: > From: Sunil Kumar Kori > > Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs") > > Signed-off-by: Sunil Kumar Kori > --- > drivers/net/dpaa/dpaa_ethdev.c | 89 > +++--- > 1 file changed, 57 inserti

[dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks

2018-04-24 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs") Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_ethdev.c | 89 +++--- 1 file changed, 57 insertions(+), 32 deletions(-) diff --git a/drivers/net/dpaa/dpaa_eth