Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-14 Thread Olivier Matz
Hi, On Fri, Jan 11, 2019 at 01:48:12PM +0100, David Marchand wrote: > On Fri, Jan 11, 2019 at 12:57 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > > > On Fri, Jan 11, 2019 at 02:17:04PM +0300, Andrew Rybchenko wrote: > > > Olivier, David, > > > > > > could you take a look at naming

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-11 Thread David Marchand
On Fri, Jan 11, 2019 at 12:57 PM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Fri, Jan 11, 2019 at 02:17:04PM +0300, Andrew Rybchenko wrote: > > Olivier, David, > > > > could you take a look at naming suggested below and share your thoughts. > > My fear is that rte_mbuf_buf_addr() is

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 02:17:04PM +0300, Andrew Rybchenko wrote: > Olivier, David, > > could you take a look at naming suggested below and share your thoughts. > My fear is that rte_mbuf_buf_addr() is too generic and true for direct mbuf > only. That's why I'd like to highlight it in the function

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-11 Thread Yongseok Koh
> On Jan 11, 2019, at 3:17 AM, Andrew Rybchenko > wrote: > > Olivier, David, > > could you take a look at naming suggested below and share your thoughts. > My fear is that rte_mbuf_buf_addr() is too generic and true for direct mbuf > only. That's why I'd like to highlight it in the function n

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-11 Thread Andrew Rybchenko
Olivier, David, could you take a look at naming suggested below and share your thoughts. My fear is that rte_mbuf_buf_addr() is too generic and true for direct mbuf only. That's why I'd like to highlight it in the function name. Thanks, Andrew. On 1/11/19 2:03 PM, Yongseok Koh wrote: On Fri, J

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-11 Thread Yongseok Koh
On Fri, Jan 11, 2019 at 11:14:22AM +0300, Andrew Rybchenko wrote: > On 1/10/19 9:35 PM, Yongseok Koh wrote: > > This patch introduces two new functions - rte_mbuf_buf_addr() and > > rte_mbuf_data_addr_default(). > > > > rte_mbuf_buf_addr() reutrns the default buffer address of given mbuf which > >

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-11 Thread Andrew Rybchenko
On 1/10/19 9:35 PM, Yongseok Koh wrote: This patch introduces two new functions - rte_mbuf_buf_addr() and rte_mbuf_data_addr_default(). rte_mbuf_buf_addr() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. rte_mbuf_data_addr_default() returns th

[dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-10 Thread Yongseok Koh
This patch introduces two new functions - rte_mbuf_buf_addr() and rte_mbuf_data_addr_default(). rte_mbuf_buf_addr() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. rte_mbuf_data_addr_default() returns the default address of mbuf data taking the