Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:36 PM > On Wed, Apr 04, 2018 at 06:23:19PM +, Matan Azrad wrote: > > Hi Pavan > > > > From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:16 PM > > > Hi Matan, > > > > > > > > > > > Got you. > > > > Looks like you found issue here... > >

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Pavan Nikhilesh
On Wed, Apr 04, 2018 at 06:23:19PM +, Matan Azrad wrote: > Hi Pavan > > From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:16 PM > > Hi Matan, > > > > > > > > Got you. > > > Looks like you found issue here... > > > The experimental tag probably should be in a root .h file. > > > Probably, need a

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:16 PM > Hi Matan, > > > > > Got you. > > Looks like you found issue here... > > The experimental tag probably should be in a root .h file. > > Probably, need a fix patch to move it for a different\new .h file. > > > > What do you think? >

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Pavan Nikhilesh
Hi Matan, > > Got you. > Looks like you found issue here... > The experimental tag probably should be in a root .h file. > Probably, need a fix patch to move it for a different\new .h file. > > What do you think? > Actually thats just start of the rabbit hole, if we succeed to tag a inline functi

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh, Wednesday, April 4, 2018 8:52 PM > On Wed, Apr 04, 2018 at 05:11:22PM +, Matan Azrad wrote: > > > > > > From: Pavan Nikhilesh, Wednesday, April 4, 2018 7:42 PM > > > Hi Matan, > > > > > > On Wed, Apr 04, 2018 at 04:10:36PM +, Matan Azrad wrote: > > > > Hi Pa

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Pavan Nikhilesh
On Wed, Apr 04, 2018 at 05:11:22PM +, Matan Azrad wrote: > > > From: Pavan Nikhilesh, Wednesday, April 4, 2018 7:42 PM > > Hi Matan, > > > > On Wed, Apr 04, 2018 at 04:10:36PM +, Matan Azrad wrote: > > > Hi Pavan > > > > > > Shouldn't the new APIs be tagged with the experimental tag as agre

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
From: Pavan Nikhilesh, Wednesday, April 4, 2018 7:42 PM > Hi Matan, > > On Wed, Apr 04, 2018 at 04:10:36PM +, Matan Azrad wrote: > > Hi Pavan > > > > Shouldn't the new APIs be tagged with the experimental tag as agreed? > > Can't tag it experimental as it causes cyclic dependency (need to i

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Pavan Nikhilesh
Hi Matan, On Wed, Apr 04, 2018 at 04:10:36PM +, Matan Azrad wrote: > Hi Pavan > > Shouldn't the new APIs be tagged with the experimental tag as agreed? Can't tag it experimental as it causes cyclic dependency (need to include rte_compact.h). Besides it's a simple proven math API I don't think

Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Matan Azrad
Hi Pavan Shouldn't the new APIs be tagged with the experimental tag as agreed? Besides that, Acked-by: Matan Azrad From: Pavan Nikhilesh, Wednesday, April 4, 2018 1:16 PM > Add 32b and 64b API's to align the given integer to the previous power of 2. > > Signed-off-by: Pavan Nikhilesh > --- >

[dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2

2018-04-04 Thread Pavan Nikhilesh
Add 32b and 64b API's to align the given integer to the previous power of 2. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Move commonly used code to rte_combine(32/64)ms1b so that it can be reused. v2 Changes: - Modified api name to `rte_align(32/64)prevpow2` from `rte_align(32/64)lowpo