Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code

2018-05-13 Thread Thomas Monjalon
14/05/2018 02:09, Andy Green: > > On 05/14/2018 07:44 AM, Thomas Monjalon wrote: > > 14/05/2018 01:21, Andy Green: > >> > >> On 05/14/2018 12:47 AM, Thomas Monjalon wrote: > >>> 12/05/2018 03:59, Andy Green: > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > In function '__

Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code

2018-05-13 Thread Andy Green
On 05/14/2018 07:44 AM, Thomas Monjalon wrote: 14/05/2018 01:21, Andy Green: On 05/14/2018 12:47 AM, Thomas Monjalon wrote: 12/05/2018 03:59, Andy Green: /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: In function '__rte_ring_move_prod_head': /projects/lagopus/src/dpdk/build/in

Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code

2018-05-13 Thread Thomas Monjalon
14/05/2018 01:21, Andy Green: > > On 05/14/2018 12:47 AM, Thomas Monjalon wrote: > > 12/05/2018 03:59, Andy Green: > >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > >> In function '__rte_ring_move_prod_head': > >> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3:

Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code

2018-05-13 Thread Andy Green
On 05/14/2018 12:47 AM, Thomas Monjalon wrote: 12/05/2018 03:59, Andy Green: /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: In function '__rte_ring_move_prod_head': /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: warning: ISO C90 forbids mixed declarations and c

Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code

2018-05-13 Thread Thomas Monjalon
12/05/2018 03:59, Andy Green: > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > In function '__rte_ring_move_prod_head': > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] >c

[dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code

2018-05-11 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: In function '__rte_ring_move_prod_head': /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] const uint32_t cons_tail = r->cons.tail;