Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-15 Thread Ferruh Yigit
On 1/15/2018 11:41 AM, Shahaf Shuler wrote: > Monday, January 15, 2018 1:34 PM, Ferruh Yigit: Currently no PMD seems implemented it. >>> >>> Sure, >>> >>> FAST_FREE offload is the logical AND between the old txqflags of: >>> ETH_TXQ_FLAGS_NOREFCOUNT >>> ETH_TXQ_FLAGS_NOMULTMEM >>> >>> The offl

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-15 Thread Shahaf Shuler
Monday, January 15, 2018 1:34 PM, Ferruh Yigit: > >> Currently no PMD seems implemented it. > > > > Sure, > > > > FAST_FREE offload is the logical AND between the old txqflags of: > > ETH_TXQ_FLAGS_NOREFCOUNT > > ETH_TXQ_FLAGS_NOMULTMEM > > > > The offload is just a performance optimization. As spe

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-15 Thread Ferruh Yigit
On 1/15/2018 11:02 AM, Shahaf Shuler wrote: > Monday, January 15, 2018 12:21 PM, Ferruh Yigit: >>> I think all of the 3 should be in a single patch. >>> The reason is that the convert patch should maintain the same offloads >> configuration needed for the application. >> >> Perhaps I am missing som

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-15 Thread Shahaf Shuler
Monday, January 15, 2018 12:21 PM, Ferruh Yigit: > > I think all of the 3 should be in a single patch. > > The reason is that the convert patch should maintain the same offloads > configuration needed for the application. > > Perhaps I am missing some details about "mbuf fast free" offload, can yo

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-15 Thread Ferruh Yigit
On 1/14/2018 10:37 AM, Shahaf Shuler wrote: > Friday, January 12, 2018 3:31 PM, Ferruh Yigit: >> On 12/26/2017 9:23 AM, Shahaf Shuler wrote: >>> Ethdev offloads API has changed since: >>> >>> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit >>> cba7f53b717d ("ethdev: introduce

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-14 Thread Shahaf Shuler
Friday, January 12, 2018 3:31 PM, Ferruh Yigit: > On 12/26/2017 9:23 AM, Shahaf Shuler wrote: > > Ethdev offloads API has changed since: > > > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit > > cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > > > This commit su

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-12 Thread Ferruh Yigit
On 12/26/2017 9:23 AM, Shahaf Shuler wrote: > Ethdev offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This commit support the new API. This patch does three things: 1- Convert

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Tuesday, December 26, 2017 9:23 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new > ethdev offloads API > > Ethdev offloa

[dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-12-26 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/l2fwd/main.c | 28 +++- 1 fi