Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 12:05 PM David Marchand wrote: > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > Hi David, > > > > Thanks for review, hopefully this patch will addresses most of the sutff. > > Rest I will address here. > > > > > > > > > + const char *procdir = "/proc/self/fd/"; > >

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 12:05 PM David Marchand wrote: > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > Hi David, > > > > Thanks for review, hopefully this patch will addresses most of the sutff. > > Rest I will address here. > > > > > > > > > + const char *procdir = "/proc/self/fd/"; > >

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 11:21 AM wrote: > > Hi David, > > Thanks for review, hopefully this patch will addresses most of the sutff. > Rest I will address here. > > > > > > + const char *procdir = "/proc/self/fd/"; > > > > self is a Linux thing. > > This won't work on FreeBSD. > > IMHO origina

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread kkanas
Hi David, Thanks for review, hopefully this patch will addresses most of the sutff. Rest I will address here. > > > + const char *procdir = "/proc/self/fd/"; > > self is a Linux thing. > This won't work on FreeBSD. IMHO original code didn't worked on FreeBSD as well. I have created funct