t: Tuesday, September 6, 2016 11:43 PM
> To: Dey, Souvik
> Cc: dev at dpdk.org; stephen at networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
>
> On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> > +static int
> > +vi
On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> +static int
> +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> +{
> + struct virtio_hw *hw = dev->data->dev_private;
> + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) {
> + PMD_INIT_LOG(ERR,
Firstly, thanks for the patch!
And I got few more style issues for you :) The first goes to the subject
(commit summary):
- the prefix is "net/virtio", but not "virtio"
- a space is needed after ':'
On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> Signed-off-by: Souvik Dey
SoB s
com]
> Sent: Tuesday, September 6, 2016 11:43 PM
> To: Dey, Souvik
> Cc: dev at dpdk.org; stephen at networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
>
> On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> > +static int
> > +vi
networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> +static int
> +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) {
> + struct virtio_hw *hw = dev->data->dev_private;
> + if (mtu <
v3]virtio:add mtu set in virtio
Firstly, thanks for the patch!
And I got few more style issues for you :) The first goes to the subject
(commit summary):
- the prefix is "net/virtio", but not "virtio"
- a space is needed after ':'
On Tue, Sep 06, 2016 at 11:21
Signed-off-by: Souvik Dey
Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ")
Reviewed-by: Stephen Hemminger
Virtio interfaces should also support setting of mtu, as in case of cloud
it is expected to have the consistent mtu across the infrastructure that
the dhcp server sends and not hardcoded t
7 matches
Mail list logo
