Re: [dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-17 Thread Maxime Coquelin
On 05/17/2018 06:50 AM, Tiwei Bie wrote: On Thu, May 17, 2018 at 06:06:34AM +0300, Michael S. Tsirkin wrote: On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote: This patch caches all dirty pages logging until the used ring index is updated. The goal of this optimization is to fi

Re: [dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Tiwei Bie
On Thu, May 17, 2018 at 06:06:34AM +0300, Michael S. Tsirkin wrote: > On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote: > > This patch caches all dirty pages logging until the used ring index > > is updated. > > > > The goal of this optimization is to fix a performance regression >

Re: [dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote: > This patch caches all dirty pages logging until the used ring index > is updated. > > The goal of this optimization is to fix a performance regression > introduced when the vhost library started to use atomic operations > to set bi

Re: [dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Tiwei Bie
On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote: > This patch caches all dirty pages logging until the used ring index > is updated. > > The goal of this optimization is to fix a performance regression > introduced when the vhost library started to use atomic operations > to set bi

[dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Maxime Coquelin
This patch caches all dirty pages logging until the used ring index is updated. The goal of this optimization is to fix a performance regression introduced when the vhost library started to use atomic operations to set bits in the shared dirty log map. While the fix was valid as previous implement