Re: [dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback

2020-10-01 Thread Ferruh Yigit
On 3/11/2020 12:26 PM, Jerin Jacob wrote: On Wed, Mar 11, 2020 at 5:52 PM Ananyev, Konstantin wrote: -Original Message- From: ZY Qiu Sent: Thursday, March 5, 2020 4:47 PM To: Thomas Monjalon ; Yigit, Ferruh ; Andrew Rybchenko Cc: dev@dpdk.org; step...@networkplumber.org; Ananyev,

Re: [dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback

2020-03-11 Thread Jerin Jacob
On Wed, Mar 11, 2020 at 5:52 PM Ananyev, Konstantin wrote: > > > > > -Original Message- > > From: ZY Qiu > > Sent: Thursday, March 5, 2020 4:47 PM > > To: Thomas Monjalon ; Yigit, Ferruh > > ; Andrew Rybchenko > > Cc: dev@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > > ;

Re: [dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback

2020-03-11 Thread Ananyev, Konstantin
> -Original Message- > From: ZY Qiu > Sent: Thursday, March 5, 2020 4:47 PM > To: Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > Cc: dev@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > ; ZY Qiu > > Subject: [PATCH v3] rte_ethdev: safer memory access by calling Rx

Re: [dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback

2020-03-05 Thread Jerin Jacob
On Thu, Mar 5, 2020 at 10:17 PM ZY Qiu wrote: > > When compiling with -O0, > the compiler does not optimize two memory accesses into one. > Leads to accessing a null pointer when queue post Rx burst callback > removal while traffic is running. > > Signed-off-by: ZY Qiu > --- > lib/librte_ethdev/

[dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback

2020-03-05 Thread ZY Qiu
When compiling with -O0, the compiler does not optimize two memory accesses into one. Leads to accessing a null pointer when queue post Rx burst callback removal while traffic is running. Signed-off-by: ZY Qiu --- lib/librte_ethdev/rte_ethdev.h | 9 + 1 file changed, 5 insertions(+), 4 d