Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-12 Thread Tone Zhang (Arm Technology China)
; Steve Capper > ; nd > Subject: Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size > with > vfio-pci driver > > On Mon, 10 Dec 2018 11:45:37 + > "Burakov, Anatoly" wrote: > > > > /* Skip this BAR */

Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-12 Thread Tone Zhang (Arm Technology China)
Hi Anatoly, Thanks for the comments. > -Original Message- > From: Burakov, Anatoly > Sent: Monday, December 10, 2018 7:46 PM > To: Tone Zhang (Arm Technology China) ; > dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; nd > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-10 Thread Stephen Hemminger
On Mon, 10 Dec 2018 11:45:37 + "Burakov, Anatoly" wrote: > > /* Skip this BAR */ > > + RTE_LOG(INFO, EAL, "Skipping BAR%d\n", bar_index); > > return 0; > > I would perhaps make it a DEBUG rather than INFO. And drop the comment...

Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-10 Thread Burakov, Anatoly
On 19-Nov-18 2:37 AM, tone.zhang wrote: With a larger PAGE_SIZE it is possible for the MSI table to very close to the end of the BAR s.t. when we align the start and end of the MSI table to the PAGE_SIZE, the end offset of the MSI table is out of the PCI BAR boundary. This patch addresses the is

Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-10 Thread Burakov, Anatoly
On 03-Dec-18 7:25 AM, Tone Zhang (Arm Technology China) wrote: Hi all, Could anyone please have a review and re-test the change? Thanks a lot! Br, Tone Tested with latest 18.11, all seems to work fine. Tested-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-02 Thread Tone Zhang (Arm Technology China)
lli ; Steve Capper > ; anatoly.bura...@intel.com; nd > Subject: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with > vfio-pci driver > > With a larger PAGE_SIZE it is possible for the MSI table to very close to the > end > of the BAR s.t. when we align th

[dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-11-18 Thread tone.zhang
With a larger PAGE_SIZE it is possible for the MSI table to very close to the end of the BAR s.t. when we align the start and end of the MSI table to the PAGE_SIZE, the end offset of the MSI table is out of the PCI BAR boundary. This patch addresses the issue by comparing both the start and the en