Re: [dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 11:47 AM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Ivan Malov [mailto:ivan.ma...@oktetlabs.ru] >> Sent: Friday, June 28, 2019 4:13 AM >> To: Olivier Matz >> Cc: dev@dpdk.org; Ananyev, Konstantin ; Andrew >> Rybchenko ; Stephen >> Hemminger ; Kulasek, To

Re: [dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

2019-06-28 Thread Ananyev, Konstantin
> -Original Message- > From: Ivan Malov [mailto:ivan.ma...@oktetlabs.ru] > Sent: Friday, June 28, 2019 4:13 AM > To: Olivier Matz > Cc: dev@dpdk.org; Ananyev, Konstantin ; Andrew > Rybchenko ; Stephen > Hemminger ; Kulasek, TomaszX > ; sta...@dpdk.org > Subject: [PATCH v3] net: fix th

Re: [dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

2019-06-27 Thread Stephen Hemminger
On Fri, 28 Jun 2019 06:13:09 +0300 Ivan Malov wrote: > The API to prepare checksum offloads mistreats L4 > checksum type enum values as self-contained flags. > > Turning these flag checks into enum checks causes > warnings by GCC about possibly uninitialised IPv4 > header pointer. The issue was

[dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

2019-06-27 Thread Ivan Malov
The API to prepare checksum offloads mistreats L4 checksum type enum values as self-contained flags. Turning these flag checks into enum checks causes warnings by GCC about possibly uninitialised IPv4 header pointer. The issue was found to show up in the case of GCC versions 4.8.5 and 5.4.0, howev