Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 5:17 PM, Ophir Munk wrote: > Hi Ferruh, > Patch https://dpdk.org/dev/patchwork/patch/38957/ was submitted. Thanks Ophir, Since your patch is out, I am marking this one as rejected. > Can you please review it? > Please add Suggest-by with your name. > > Regards, > Ophir > >> -

Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ophir Munk
Hi Ferruh, Patch https://dpdk.org/dev/patchwork/patch/38957/ was submitted. Can you please review it? Please add Suggest-by with your name. Regards, Ophir > -Original Message- > From: Ophir Munk > Sent: Wednesday, April 25, 2018 3:21 PM > To: 'Ferruh Yigit' ; 'Pascal Mazon' > > Cc: 'dev

Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ophir Munk
Hi Ferruh, I started working on a patch. No need for your test example. > -Original Message- > From: Ophir Munk > Sent: Wednesday, April 25, 2018 3:00 PM > To: 'Ferruh Yigit' ; Pascal Mazon > > Cc: dev@dpdk.org; Mordechay Haimovsky ; Olga > Shern ; Thomas Monjalon ; > Raslan Darawsheh ; S

Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ophir Munk
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 25, 2018 12:48 PM > To: Ophir Munk ; Pascal Mazon > > Cc: dev@dpdk.org; Mordechay Haimovsky ; Olga > Shern ; Thomas Monjalon ; > Raslan Darawsheh ; Shahaf Shuler > > Subject: Re: [PATCH v3

Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 10:18 AM, Ophir Munk wrote: > Hi Ferruh, > > I should have mentioned earlier that TAP does support queue specific > capabilities. > Please look in tap_queue_setup() and note that each TAP queue is created with > a distinct file descriptor (fd). > Then supporting an offload capabili

Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ophir Munk
Hi Ferruh, I should have mentioned earlier that TAP does support queue specific capabilities. Please look in tap_queue_setup() and note that each TAP queue is created with a distinct file descriptor (fd). Then supporting an offload capability is just implementing it in SW (e.g. calculating IP

[dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-24 Thread Ferruh Yigit
It is not clear if tap PMD supports queue specific offloads, removing the related code. Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") Cc: mo...@mellanox.com Signed-off-by: Ferruh Yigit --- Cc: Ophir Munk v2: * rebased v3: * t