Hi Ophir,
Thanks for inputs, please find my answers inline to the mail
> -Original Message-
> From: Ophir Munk [mailto:ophi...@mellanox.com]
> Sent: Tuesday, May 22, 2018 8:35 PM
> To: Varghese, Vipin ; dev@dpdk.org; Yigit, Ferruh
> ; Wiles, Keith
> Cc: Thomas Monjalon ; Olga Shern
>
>
HI Keith,
Thanks for pointing out, please find my answer and update below
> > + /*
> > +* TUN and TAP are created with IFF_NO_PI disabled.
> > +* For TUN PMD this mandatory as fields are used by
> > +* Kernel tun.c t
Hi,
Overall it looks good.
Please note a few more comments below.
> -Original Message-
> From: Vipin Varghese [mailto:vipin.vargh...@intel.com]
> Sent: Tuesday, May 22, 2018 1:47 PM
> To: dev@dpdk.org; ferruh.yi...@intel.com; keith.wi...@intel.com; Ophir
> Munk
> Cc: Thomas Monjalon ; Olg
> On May 22, 2018, at 5:47 AM, Varghese, Vipin wrote:
>
> The TX function is shared between TAP and TUN PMD. Checking TUN-TAP
> type field will ensure the TAP PMD will always have protocol field
> as 0.
>
> Signed-off-by: Vipin Varghese
> Suggested-by: Ferruh Yigit
> ---
> Changes in V3:
> -
The TX function is shared between TAP and TUN PMD. Checking TUN-TAP
type field will ensure the TAP PMD will always have protocol field
as 0.
Signed-off-by: Vipin Varghese
Suggested-by: Ferruh Yigit
---
Changes in V3:
- remove type field from rx struct - Ophir Munk
- add space for comment in stru
5 matches
Mail list logo
