> -Original Message-
> From: Singh, Jasvinder
> Sent: Wednesday, July 14, 2021 7:08 PM
> To: Yu, DapengX ; Dumitrescu, Cristian
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH v3] net/softnic: fix memory leak in parsing arguments
>
>
>
> > + free(firmware);
>
> Memory
> + free(firmware);
Memory for firmware is not allocated dynamically, so no need for this.
> struct pmd_params {
> - const char *name;
> - const char *firmware;
> + char name[RTE_DEV_NAME_MAX_LEN];
Please replace " RTE_DEV_NAME_MAX_LEN " with "NAME_SIZE" which is already
de
From: Dapeng Yu
In function pmd_parse_args(), firmware path is duplicated from device
arguments as character string, but is never freed, which cause memory
leak.
This patch changes the type of firmware member of struct pmd_params to
character array, to make memory resource release unnecessary, a
3 matches
Mail list logo
