On Wed, 2019-03-06 at 15:51 +0100, Rastislav Černay wrote:
> >
> > --Why is -lfdt added? I don't see any symbols from libfdt used in
> > the
> > --rest of the patch?
> >
>
> Hi,
> libnfb is dependent on fdt and there is a special case, where some
> functions are defined in header (netcope/rxmac.
>
>
> --Why is -lfdt added? I don't see any symbols from libfdt used in the
> --rest of the patch?
>
Hi,
libnfb is dependent on fdt and there is a special case, where some
functions are defined in header (netcope/rxmac.h, netcope/txmac.h).
So if one wants to use functions, from these headers fdt n
On Fri, 2019-03-01 at 15:37 +0100, Rastislav Cernay wrote:
> From: Rastislav Cernay
>
> Added new net driver for Netcope nfb cards
>
> Signed-off-by: Rastislav Cernay
> ---
> v2: remove unnecessary cast
> remove unnecessary zeroing
> move declaration to not mix with code
> restore s
Hi,
Added new net driver for Netcope nfb cards
Signed-off-by: Rastislav Cernay
Reviewed-by: Rami Rosen
---
v2: remove unnecessary cast
remove unnecessary zeroing
move declaration to not mix with code
restore skeleton example
v3: add release notes
add doc to doc index
add arc
>>>How about looping on min(nb_tx, RTE_ETHDEV_QUEUE_STAT_CNTRS) ?
This would lead to incomplete tx_total (and other total) stats. Maybe I
could just
add commentary, why it is written like this and leave it be?
On Mon, Mar 4, 2019 at 1:48 PM David Marchand
wrote:
> On Mon, Mar 4, 2019 at 1:35 PM
On Mon, Mar 4, 2019 at 1:35 PM David Marchand
wrote:
>
>
> On Mon, Mar 4, 2019 at 1:30 PM Rastislav Černay
> wrote:
>
>> >>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ?
>>
>> struct rte_eth_stats {
>> ...
>> uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
>> ...
>> }
>>
On Mon, Mar 4, 2019 at 1:30 PM Rastislav Černay wrote:
> >>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ?
>
> struct rte_eth_stats {
> ...
> uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
> ...
> }
>
> As there can be more queues (nb_tx) then RTE_ETHDEV_QUEUE_STAT_CNTRS (
>>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ?
struct rte_eth_stats {
...
uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]
...
}
As there can be more queues (nb_tx) then RTE_ETHDEV_QUEUE_STAT_CNTRS (16)
and struct rte_eth_stats eth_stats is allocated statically,
there is
Typically device works in promiscuous mode and filtering/processing is done
after
packets are received, use of MACS is a marginal case so we are not exactly
focused
on it. I will add random ethernet address so card can work in initial state
with multiple
devices.
On Fri, Mar 1, 2019 at 7:47 PM
On Fri, Mar 1, 2019 at 3:38 PM Rastislav Cernay wrote:
> diff --git a/drivers/net/nfb/nfb_stats.c b/drivers/net/nfb/nfb_stats.c
> new file mode 100644
> index 000..ffc27a5
> --- /dev/null
> +++ b/drivers/net/nfb/nfb_stats.c
> @@ -0,0 +1,78 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + *
On Fri, Mar 1, 2019 at 7:50 PM Stephen Hemminger
wrote:
> On Fri, 1 Mar 2019 15:37:34 +0100
> Rastislav Cernay wrote:
>
> > From: Rastislav Cernay
> >
> > Added new net driver for Netcope nfb cards
> >
> > Signed-off-by: Rastislav Cernay
> > ---
>
> Please fix these obvious style issues from
On Fri, 1 Mar 2019 15:37:34 +0100
Rastislav Cernay wrote:
> From: Rastislav Cernay
>
> Added new net driver for Netcope nfb cards
>
> Signed-off-by: Rastislav Cernay
> ---
Please fix these obvious style issues from checkpatches
ERROR:SPACING: space required before the open brace '{'
#934:
On Fri, 1 Mar 2019 15:37:34 +0100
Rastislav Cernay wrote:
> +/**
> + * Default MAC addr
> + */
> +static struct ether_addr eth_addr = {
> + .addr_bytes = { 0x00, 0x11, 0x17, 0x00, 0x00, 0x00 }
You might want to consider using a random ethernet address.
What does the device do on Linux?
From: Rastislav Cernay
Added new net driver for Netcope nfb cards
Signed-off-by: Rastislav Cernay
---
v2: remove unnecessary cast
remove unnecessary zeroing
move declaration to not mix with code
restore skeleton example
v3: add release notes
add doc to doc index
add architec
14 matches
Mail list logo
