Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-06 Thread Adrien Mazarguil
aranjeiro ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event > > > > Hi Matan, > > > > On Tue, Sep 05, 2017 at 10:38:21AM +, Matan Azrad wrote: > > > Hi Adrien > > > > > > > -Origi

Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-05 Thread Matan Azrad
Hi Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, September 5, 2017 3:02 PM > To: Matan Azrad > Cc: Nélio Laranjeiro ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal e

Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-05 Thread Adrien Mazarguil
Cc: Nélio Laranjeiro ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event > > > > Hi Matan, > > > > On Mon, Sep 04, 2017 at 05:52:55PM +, Matan Azrad wrote: > > > Hi Adrien, > > > > > > > -Origi

Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-05 Thread Matan Azrad
Hi Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, September 5, 2017 12:28 PM > To: Matan Azrad > Cc: Nélio Laranjeiro ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal e

Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-05 Thread Adrien Mazarguil
aranjeiro ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event > > > > Hi Matan, > > > > One comment I have is, while this patch adds support for RMV, it also > > silently > > addresses a bug (see large comment you

Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-04 Thread Matan Azrad
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, September 4, 2017 6:33 PM > To: Matan Azrad > Cc: Nélio Laranjeiro ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal e

Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-04 Thread Adrien Mazarguil
Hi Matan, One comment I have is, while this patch adds support for RMV, it also silently addresses a bug (see large comment you added to priv_link_status_update()). This should be split in two commits, with the fix part coming first and CC sta...@dpdk.org, and a second commit adding RMV support p

[dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-04 Thread Matan Azrad
Extend the LSC event handling to support the device removal as well. The Verbs library may send several related events, which are different from LSC event. The mlx5 event handling has been made capable of receiving and signaling several event types at once. This support includes next: 1. Removal