Re: [dpdk-dev] [PATCH v3] net/mlx4: support hardware TSO

2018-06-28 Thread Matan Azrad
Hi Moti I started to review it but not finished all :) Please see some comments\questions, I will continue the review again in the next version, after addressing the next comments and Adrien comments. From: Mordechay Haimovsky > + * No TSO SIZE is defined in DPDK, need to figure it

Re: [dpdk-dev] [PATCH v3] net/mlx4: support hardware TSO

2018-06-28 Thread Adrien Mazarguil
Hi Moti, On Thu, Jun 28, 2018 at 03:48:57PM +0300, Moti Haimovsky wrote: > Implement support for hardware TSO. > > Signed-off-by: Moti Haimovsky I only glanced at the code but overall TSO logic appears to be sound; assuming it went through non-regression I think it's OK. Please see below for a

[dpdk-dev] [PATCH v3] net/mlx4: support hardware TSO

2018-06-28 Thread Moti Haimovsky
Implement support for hardware TSO. Signed-off-by: Moti Haimovsky --- v3: * Fixed compilation errors in compilers without GNU C extensions caused by a declaration of zero-length array in the code. in reply to 1530187032-6489-1-git-send-email-mo...@mellanox.com v2: * Fixed coding style warning.