Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-09 Thread Ferruh Yigit
On 10/9/2020 8:48 AM, Sachin Saxena (OSS) wrote: On 08-Oct-20 6:42 PM, Ferruh Yigit wrote: On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: [please don't top post, I moved reply to down] On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: From: Chenxu Di Some timesync related source files are buil

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 08-Oct-20 6:42 PM, Ferruh Yigit wrote: On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: [please don't top post, I moved reply to down] On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: From: Chenxu Di Some timesync related source files are built only when 'RTE_LIBRTE_I

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-08 Thread Ferruh Yigit
On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: [please don't top post, I moved reply to down] On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: From: Chenxu Di Some timesync related source files are built only when 'RTE_LIBRTE_IEEE1588' config is set, which is missing in meson. Building with '-D

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-07 Thread Sachin Saxena (OSS)
Following change should also be handled as suggested by Ferruh in earlier. diff --git a/drivers/net/dpaa2/dpaa2_ptp.c b/drivers/net/dpaa2/dpaa2_ptp.c index 9f755e84bf..0e44d4c6bf 100644 --- a/drivers/net/dpaa2/dpaa2_ptp.c +++ b/drivers/net/dpaa2/dpaa2_ptp.c @@ -178,4 +178,6 @@ s

[dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-06 Thread Ferruh Yigit
From: Chenxu Di Some timesync related source files are built only when 'RTE_LIBRTE_IEEE1588' config is set, which is missing in meson. Building with '-DRTE_LIBRTE_IEEE1588' cflag will enable timesync functionality in the files that are build, but it won't build files that require 'RTE_LIBRTE_IEE